Fixes for amount conversion & BigNumber lib de-duping #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently use BigNumber.js across the Utils package - Fixes #2751 No, minor adjustments needed where the utils consumers expected Ethers BigNumbers Created unit tests
Create unit tests for some amount fns Run utils unit tests in CI
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3 #2913 +/- ##
=======================================
Coverage 67.94% 67.94%
=======================================
Files 99 99
Lines 1017 1017
Branches 106 106
=======================================
Hits 691 691
Misses 286 286
Partials 40 40
|
yorhodes
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
https://github.com/hyperlane-xyz/issues/issues/690
#2751
#2828
Backward compatibility
No, minor breaking changes to signatures of amount util fns
Testing
Unit tests