Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core contract caching and recovery #2932

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Fix core contract caching and recovery #2932

merged 8 commits into from
Nov 17, 2023

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Nov 16, 2023

  • Fix core contract recovery
  • Simplify deployment plan text
  • Soften balance warning message

@jmrossy jmrossy enabled auto-merge (squash) November 16, 2023 21:39
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2932 (bca7d5f) into main (874f366) will decrease coverage by 0.10%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
- Coverage   67.57%   67.48%   -0.10%     
==========================================
  Files         101      101              
  Lines        1024     1024              
  Branches      106      106              
==========================================
- Hits          692      691       -1     
  Misses        293      293              
- Partials       39       40       +1     
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 71.42% <ø> (ø)
isms 70.50% <ø> (-0.72%) ⬇️
token 54.62% <ø> (ø)
middlewares 81.46% <ø> (ø)

typescript/cli/src/deploy/core.ts Show resolved Hide resolved
typescript/sdk/src/consts/chainMetadata.ts Outdated Show resolved Hide resolved
@jmrossy jmrossy disabled auto-merge November 17, 2023 16:27
@jmrossy jmrossy merged commit bbe8071 into main Nov 17, 2023
24 of 26 checks passed
@jmrossy jmrossy deleted the rossy/cli-cache-fix branch November 17, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants