Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn changesets #2949

Merged
merged 11 commits into from
Nov 22, 2023
Merged

Add yarn changesets #2949

merged 11 commits into from
Nov 22, 2023

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Nov 21, 2023

Description

  • monorepo commands will only run for packages which have changed since baseRef: main

Drive-by changes

  • modify github actions to leverage filtered behavior
  • upgrade to yarn 4.0.2

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Nov 21, 2023

⚠️ No Changeset found

Latest commit: db58ae1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aroralanuk
Copy link
Contributor

Where did you put the test-sol job, it's missing from node.yaml? Also coverage should be triggered on `solidity/* path too?

@yorhodes
Copy link
Member Author

Where did you put the test-sol job, it's missing from node.yaml? Also coverage should be triggered on `solidity/* path too?

I renamed it because it now includes the sol and ts tests
coverage will be triggered for any workspace that has a diff, including solidity

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/node.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
@aroralanuk
Copy link
Contributor

Where did you put the test-sol job, it's missing from node.yaml? Also coverage should be triggered on `solidity/* path too?

I renamed it because it now includes the sol and ts tests coverage will be triggered for any workspace that has a diff, including solidity

isn't this adding time and blocking non-solidity tests by checking solidity tests

@yorhodes
Copy link
Member Author

I renamed it because it now includes the sol and ts tests coverage will be triggered for any workspace that has a diff, including solidity

isn't this adding time and blocking non-solidity tests by checking solidity tests

for some PRs, it may result in a slight increase in runtime yes...
the test-sol dominated runtime anyway so I think this should be fine

@yorhodes yorhodes enabled auto-merge November 22, 2023 16:11
@yorhodes yorhodes merged commit ef9c09b into main Nov 22, 2023
15 checks passed
@yorhodes yorhodes deleted the changesets branch November 22, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants