Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook metadata improvements #2953

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Hook metadata improvements #2953

merged 6 commits into from
Nov 22, 2023

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Nov 21, 2023

Description

  • Improves StandardHookMetadata interface to be more explicit

Drive-by changes

  • Update usage across hooks and routers

Related issues

Backward compatibility

  • No but minimally used

Testing

Unit Tests

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 6044fb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2953 (c9e0aed) into main (8db8fcd) will increase coverage by 0.03%.
Report is 15 commits behind head on main.
The diff coverage is 50.00%.

❗ Current head c9e0aed differs from pull request most recent head 6044fb8. Consider uploading reports for the commit 6044fb8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2953      +/-   ##
==========================================
+ Coverage   67.57%   67.61%   +0.03%     
==========================================
  Files         101      101              
  Lines        1024     1022       -2     
  Branches      106      106              
==========================================
- Hits          692      691       -1     
+ Misses        293      292       -1     
  Partials       39       39              
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 70.92% <50.00%> (-0.51%) ⬇️
isms 71.22% <ø> (ø)
token 54.62% <ø> (ø)
middlewares 81.46% <ø> (ø)

@yorhodes yorhodes enabled auto-merge November 22, 2023 18:49
@yorhodes yorhodes merged commit 83335b4 into main Nov 22, 2023
15 of 16 checks passed
@yorhodes yorhodes deleted the hook-metadata-improvements branch November 22, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants