Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): support DefaultFallbackRoutingIsm in sdk metadata builder #4162

Merged

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Jul 17, 2024

Description

Support DefaultFallbackRoutingIsm in sdk metadata builder

Backward compatibility

Yes

Testing

Manually processed https://explorer.hyperlane.xyz/message/0x7d5f8450965a97735e39007f7cb9db135852123d589d81f81c113d84e3a70ceb

@nambrot nambrot requested review from yorhodes and jmrossy as code owners July 17, 2024 18:18
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 2a85930

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nambrot nambrot enabled auto-merge July 17, 2024 18:19
@nbayindirli nbayindirli changed the title Support DefaultFallbackRoutingIsm in sdk metadata builder chore(sdk): support DefaultFallbackRoutingIsm in sdk metadata builder Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (dac2fb5) to head (2a85930).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4162   +/-   ##
=======================================
  Coverage   73.24%   73.24%           
=======================================
  Files         100      100           
  Lines        1413     1413           
  Branches      178      178           
=======================================
  Hits         1035     1035           
  Misses        357      357           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 72.38% <ø> (ø)
isms 78.41% <ø> (ø)
token 88.88% <ø> (ø)
middlewares 77.39% <ø> (ø)

@nambrot nambrot added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 3ad5918 Aug 26, 2024
31 of 36 checks passed
@nambrot nambrot deleted the nambrot/support-fallback-routing-in-sdk-metadata-builder branch August 26, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants