Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not start up validator if fraud was reported #4627

Merged
merged 15 commits into from
Oct 7, 2024
Merged

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Oct 4, 2024

Description

Builds on top of #4587

Adds a check in the CheckpointSubmitter builder which emits a panic if a reorg flag was posted, since this potentially signals fraud

Drive-by changes

CheckpointSubmitter::build was made private, so any use of it is now replaced by the build_and_submit flow

Related issues

Backward compatibility

Yes

Testing

Unit Tests - which is enough as long as CheckpointSubmitter::build is kept private

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 0e4576e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.89%. Comparing base (8809f37) to head (0e4576e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4627   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files         100      100           
  Lines        1421     1421           
  Branches      180      180           
=======================================
  Hits         1050     1050           
  Misses        350      350           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 75.71% <ø> (ø)
isms 79.20% <ø> (ø)
token 88.23% <ø> (ø)
middlewares 77.39% <ø> (ø)

@daniel-savu daniel-savu marked this pull request as ready for review October 7, 2024 11:10
@daniel-savu daniel-savu requested a review from tkporter as a code owner October 7, 2024 11:10
@daniel-savu daniel-savu changed the title wip: do not start up validator if fraud was reported feat: do not start up validator if fraud was reported Oct 7, 2024
@daniel-savu daniel-savu added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 7dccf80 Oct 7, 2024
36 checks passed
@daniel-savu daniel-savu deleted the dan/fraud-flag branch October 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants