-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: do not start up validator if fraud was reported #4627
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4627 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 100 100
Lines 1421 1421
Branches 180 180
=======================================
Hits 1050 1050
Misses 350 350
Partials 21 21
|
Description
Builds on top of #4587
Adds a check in the
CheckpointSubmitter
builder which emits a panic if a reorg flag was posted, since this potentially signals fraudDrive-by changes
CheckpointSubmitter::build
was made private, so any use of it is now replaced by thebuild_and_submit
flowRelated issues
Backward compatibility
Yes
Testing
Unit Tests - which is enough as long as
CheckpointSubmitter::build
is kept private