-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(warpMonitor): Add validator_names label to warp balance monitor metric #4917
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4917 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
0f4db2f
to
198aca0
Compare
@@ -76,6 +88,13 @@ export function updateTokenBalanceMetrics( | |||
.filter((chainName) => chainName !== token.chainName) | |||
.sort() | |||
.join(','), | |||
validator_names: defaultMultisigConfigs[token.chainName].validators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are making the assumption that all warp routes are using the defaultISM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considered filtering out warp routes that do not use the defaultISM using the deploy config or reading on-chain state. The problem with this is that it would exclude routes like Renzo which has a lot of value that we want to account for as its ISM is an aggregation that includes the defaultISM. Discussed this with @nambrot a while back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I primarily worry about value that uses the default ISM exclusively, so i would be ok with excluding warp routes like renzo for now. Obviously ideally, I would like a dashboard that segments these appropriately
Description
Backward compatibility
hyperlane_warp_route_token_balance
metric as we are adding new labels which will mean that All warp route diffs, the warp routes and xERC20 related dashboards will switch to using a different time series. Whilst not ideal as the graphs will look weird, the downside is not significant