Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(infra): added the getEthereumFormUSDTWarpConfig func #5056

Merged
merged 9 commits into from
Jan 14, 2025
Merged

feat(infra): added the getEthereumFormUSDTWarpConfig func #5056

merged 9 commits into from
Jan 14, 2025

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Dec 19, 2024 •
edited
Loading

Description

Adds the warp route config getter for the USDT route on Form network

associated registry PR hyperlane-xyz/hyperlane-registry#449

Drive-by changes

  • NO

Backward compatibility

-YES

Testing

  • Manual

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 033fa7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xeno097 xeno097 requested a review from nambrot December 19, 2024 20:42
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (7bf0abf) to head (033fa7f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5056   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

paulbalaji
paulbalaji reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@paulbalaji paulbalaji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I please request that every warp config/monitor PR to the monorepo is linked to a corresponding registry PR with the new config please, since we know that each new route here requires an updated .registryrc

it will make it easy to review two birds in one stone, a la new chain deploy PRs which reference both registry+monorepo PRs together

@xeno097 xeno097 mentioned this pull request Dec 20, 2024
Merged
cmcewen
cmcewen previously requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@cmcewen cmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests not all passing

@xeno097
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
b715dc9 
…to xeno/ethereum-form-usdt-warp-route-config-getter
github-merge-queue bot pushed a commit to hyperlane-xyz/hyperlane-registry that referenced this pull request Jan 13, 2025
@xeno097 @nambrot
feat: added the ethereum-form usdt/usdc route (#449)
52f72b3 
### Description

Adds the ethereum-form usdt warp route deployed using the config at
hyperlane-xyz/hyperlane-monorepo#5056

### Backward compatibility

- YES

### Testing

Manual

---------

Co-authored-by: nambrot <[email protected]>
@xeno097 xeno097 enabled auto-merge January 14, 2025 17:23
@xeno097 xeno097 added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 9574b1b Jan 14, 2025
42 checks passed
@xeno097 xeno097 deleted the xeno/ethereum-form-usdt-warp-route-config-getter branch January 14, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot approved these changes

@Mo-Hussain Mo-Hussain Awaiting requested review from Mo-Hussain Mo-Hussain is a code owner

@cmcewen cmcewen Awaiting requested review from cmcewen

@paulbalaji paulbalaji Awaiting requested review from paulbalaji paulbalaji is a code owner

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xeno097 @nambrot @cmcewen @paulbalaji @tkporter