Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents/sealevel): handle non configured igp account payments #5075

Merged
merged 35 commits into from
Jan 13, 2025

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Dec 26, 2024

Description

  • Handles the case where igp fees are paid to a non-configured igp account in a backward compatible way.
    • Zero out payment for non-matching igp accounts so that the db stays continuous to prevent an infinite loop in the sequencer aware parser but at the same time, enforce payments to the right igp account was made before processing the message.

Note: If we want to display these neutralized payments (in say, the Explorer), we'll need to think of a more breaking solution, which isn't necessary today.

Drive-by changes

None

Related issues

Backward compatibility

Yes

Testing

  • integration test paying to a different newly deployed account

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 557b0b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (6c6d2bc) to head (557b0b5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5075   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought about it, I'm down to do this for now but let's add a comment clearly flagging why we did this / what the impact is / indicating we may want to change in the future if we want to index multiple IGPs at a time

rust/main/chains/hyperlane-sealevel/src/interchain_gas.rs Outdated Show resolved Hide resolved
@aroralanuk aroralanuk changed the base branch from main to kunal/reenble-igp-enforcement January 8, 2025 15:15
@aroralanuk aroralanuk marked this pull request as ready for review January 8, 2025 15:57
@aroralanuk aroralanuk requested a review from tkporter January 8, 2025 16:04
Base automatically changed from kunal/reenble-igp-enforcement to main January 13, 2025 16:45
@aroralanuk aroralanuk enabled auto-merge January 13, 2025 16:51
@aroralanuk aroralanuk added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit b505997 Jan 13, 2025
42 checks passed
@aroralanuk aroralanuk deleted the kunal/index-other-igps branch January 13, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants