Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TONY warp deploy, fix CLI warp deploys with non-EVM chains #5186

Merged
merged 8 commits into from
Jan 16, 2025

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Jan 15, 2025

Description

  • Deploys TONY
  • There was an issue with a non-EVM chain being in the warp deploy config. I made the fix but ultimately we should have a unit test to prevent this. Would prefer someone closer to the feature to do this, I just did a band aid fix

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 66deee4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (9eb19ca) to head (5aabac4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5186   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@tkporter tkporter changed the title [wip] TONY warp deploy feat: TONY warp deploy Jan 15, 2025
@tkporter tkporter marked this pull request as ready for review January 15, 2025 18:46
@tkporter tkporter changed the title feat: TONY warp deploy feat: TONY warp deploy, fix CLI warp deploys with non-EVM chains Jan 15, 2025
@tkporter tkporter added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@tkporter tkporter added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 69a6848 Jan 16, 2025
49 checks passed
@tkporter tkporter deleted the trevor/tony branch January 16, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants