Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve scraper startup error handling #5191

Merged
merged 4 commits into from
Jan 21, 2025
Merged

feat: improve scraper startup error handling #5191

merged 4 commits into from
Jan 21, 2025

Conversation

kamiyaa
Copy link
Collaborator

@kamiyaa kamiyaa commented Jan 16, 2025

Description

  • handle errors and sets set chain metrics if scraper fails for chain during startup

Drive-by changes

  • implement Clone for ScraperDb
    • this is because DbConn doesn't implement Clone when mock feature is enabled

Related issues

Fixes https://github.com/hyperlane-xyz/issues/issues/1408

Backward compatibility

Yes

Testing

Added unittest to test function. But don't have tests in place for testing the logic in Scraper::run()

 - set chain metrics if scraper fails for chain during startup
Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: 94d1f9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kamiyaa kamiyaa requested a review from ameten January 16, 2025 14:32
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (9eb19ca) to head (94d1f9d).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5191   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@ameten ameten added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 0372ff9 Jan 21, 2025
42 checks passed
@ameten ameten deleted the jeff/scraper-rpc branch January 21, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants