Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Mailbox Default Hook in the SDK #5435

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Feb 11, 2025

Description

feat: support Mailbox Default Hook in the SDK

  • mimic the merkletree hook boilerplate
  • update EvmHookModule, HyperlaneHookDeployer
  • update EvmHookReader

Drive-by changes

Related issues

Backward compatibility

yes

Testing

unit tests

Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 0cc7e03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paulbalaji paulbalaji requested review from nambrot and removed request for jmrossy February 11, 2025 17:20
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (9a010df) to head (0cc7e03).
Report is 1 commits behind head on ccip-warp-route.

Additional details and impacted files
@@               Coverage Diff                @@
##           ccip-warp-route    #5435   +/-   ##
================================================
  Coverage            77.11%   77.11%           
================================================
  Files                  109      109           
  Lines                 2163     2163           
  Branches               193      193           
================================================
  Hits                  1668     1668           
  Misses                 474      474           
  Partials                21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 77.93% <ø> (ø)
isms 81.60% <ø> (ø)
token 91.66% <ø> (ø)
middlewares 79.80% <ø> (ø)

Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from default-hook to ccip-warp-route February 11, 2025 22:05
@paulbalaji paulbalaji merged commit cb7c157 into ccip-warp-route Feb 11, 2025
37 of 38 checks passed
@paulbalaji paulbalaji deleted the pb/defaulthook-sdk branch February 11, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants