-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move registry functions to @hyperlane-xyz/registry #5491
base: main
Are you sure you want to change the base?
refactor: move registry functions to @hyperlane-xyz/registry #5491
Conversation
🦋 Changeset detectedLatest commit: c127f48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but pending merge based on a registry release
b42e078
to
c127f48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5491 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
🚀 New features to boost your workflow:
|
Description
This PR moves the registry-related functionality from the CLI package to the dedicated
@hyperlane-xyz/registry
package. The main changes include:getRegistry()
function and its dependencies from CLI to registry packagegetRegistry()
function for better logging controlDrive-by changes
None
Related issues
resolves #5403
Backward compatibility
Yes - This is a pure refactor with no functional changes
Testing
Unit Tests - Existing tests were updated to use the new import paths
Note: This PR depends on hyperlane-xyz/hyperlane-registry#592 which introduces the unified registry utility functions and should be merged first.