Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move registry functions to @hyperlane-xyz/registry #5491

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mshojaei-txfusion
Copy link
Collaborator

@mshojaei-txfusion mshojaei-txfusion commented Feb 17, 2025

Description

This PR moves the registry-related functionality from the CLI package to the dedicated @hyperlane-xyz/registry package. The main changes include:

  • Relocating getRegistry() function and its dependencies from CLI to registry package
  • Updating imports across the codebase to use the new location
  • Adding logger parameter to getRegistry() function for better logging control

Drive-by changes

None

Related issues

resolves #5403

Backward compatibility

Yes - This is a pure refactor with no functional changes

Testing

Unit Tests - Existing tests were updated to use the new import paths

Note: This PR depends on hyperlane-xyz/hyperlane-registry#592 which introduces the unified registry utility functions and should be merged first.

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: c127f48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/infra Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but pending merge based on a registry release

@mshojaei-txfusion mshojaei-txfusion force-pushed the refactor/move-get-registry-to-registry-package branch from b42e078 to c127f48 Compare March 7, 2025 13:35
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (b901822) to head (c127f48).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5491   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Move getRegistry to registry package
2 participants