-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check-deploy with --registry #5621
base: main
Are you sure you want to change the base?
Conversation
|
export function getCheckDeployArgs() { | ||
return withWarpRouteId(withModule(getCheckBaseArgs())); | ||
return withGithubCommit( | ||
withWarpRouteIdNoChoices(withModule(getCheckBaseArgs())), | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will break a lot of existing flows if we're now demanding that a github commit has to be required with every check-deploy call - imo it should still be optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is optional though
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5621 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
🚀 New features to boost your workflow:
|
typescript/infra/config/registry.ts
Outdated
@@ -104,6 +108,36 @@ export function getWarpCoreConfig(warpRouteId: string): WarpCoreConfig { | |||
return warpRouteConfig; | |||
} | |||
|
|||
export async function getWarpCoreConfigFromGithubFileSystem( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's kinda an odd function name?
8a51b92
to
eba159d
Compare
Description
This PR
--registry
instead of having to check out the Registry branch. This is similar to how CLI's parameter.--registry
--registry
--warpRouteId
to be filled in and no longer depend on the warpRouteIds mappingDrive-by
Ups the Registry to 10.10.0 which includes the new branch parameter
Related issues
Backward compatibility
Yes - We now fetch from the FileSystem and Github Registry instead of just FileSystem
Testing
Manual