Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check-deploy with --registry #5621

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Mar 6, 2025

Description

This PR

  • allows check-deploy to run with a --registry instead of having to check out the Registry branch. This is similar to how CLI's parameter.
  • Update getConfigFromMergedRegistry() to fetch from the array in --registry
  • Adds new functions getWarpCoreConfigFromMergedRegistry() and getWarpAddressesFromMergedRegistry() to fetch from the array in --registry
  • requires --warpRouteId to be filled in and no longer depend on the warpRouteIds mapping

Drive-by

Ups the Registry to 10.10.0 which includes the new branch parameter

Related issues

Backward compatibility

Yes - We now fetch from the FileSystem and Github Registry instead of just FileSystem

Testing

Manual

@ltyu ltyu requested review from nambrot and xeno097 March 6, 2025 21:37
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 37a393f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ltyu ltyu requested review from yorhodes, Xaroz and cmcewen as code owners March 6, 2025 21:39
@ltyu ltyu removed request for cmcewen, tkporter and Xaroz March 6, 2025 21:41
Comment on lines 69 to 71
export function getCheckDeployArgs() {
return withWarpRouteId(withModule(getCheckBaseArgs()));
return withGithubCommit(
withWarpRouteIdNoChoices(withModule(getCheckBaseArgs())),
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break a lot of existing flows if we're now demanding that a github commit has to be required with every check-deploy call - imo it should still be optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is optional though

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (7c95140) to head (37a393f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5621   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -104,6 +108,36 @@ export function getWarpCoreConfig(warpRouteId: string): WarpCoreConfig {
return warpRouteConfig;
}

export async function getWarpCoreConfigFromGithubFileSystem(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's kinda an odd function name?

@ltyu ltyu force-pushed the ltyu/check-deploy-with-commit branch from 8a51b92 to eba159d Compare March 7, 2025 21:20
@ltyu ltyu changed the title feat: check-deploy with commit feat: check-deploy with --registry Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

infra's check-deploy can be run with a command line arg for registry commit
3 participants