Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Run multiple validators in one process #5626

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

keefertaylor
Copy link

Description

This PR enables multiple validators to run in a single process.

This introduces a few changes to the settings file and how settings are parsed:

  • DB paths are automatically namespaced with the chain name as a subfolder
  • S3 buckets are automatically namespaced with the chain name as a subfolder
  • The field originchainname (type string) becomes originchainnames (type array<string>)

Besides setting parsing the implementation:

  • Renames Validator/ValidatorSettings to ChainValidator/ChainValidatorSettings. Logically this is a validator bound to a single chain
  • Creates a new Validator/ValidatorSettings struct in it's place, which is a class that holds singleton object and one or more ChainValidators.

Other than that changes are fairly straightforward:

  • Use multithreaded tokio runtime since we're now doing parallelizable work and using a single thread tends to starve the tokio runtime since some tasks (ie. backfill) are long running
  • Break API server out and have it run once, rather than once per validator (otherwise it will fail since it will try to bind the same port n times
  • Instrument tokio_spawn with chain names so that we can tell which chain is producting logs
  • Break out metrics as a singleton so each ChainValidator can update metrics

Open Questions:

  • Does interval need to vary on a chain by chain basis or can it be set to. static value for all chains
  • How do we maintain backward compatibility with existing settings files?

Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 7318e5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant