Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge SDK + Hardhat + Deploy packages #643

Merged
merged 38 commits into from
Jul 5, 2022
Merged

Merge SDK + Hardhat + Deploy packages #643

merged 38 commits into from
Jul 5, 2022

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Jun 23, 2022 •
edited
Loading

Fixes #543

  • Merge hardhat package into SDK
  • Merge deploy package into SDK
  • Reorganize SDK consts and utils
  • Rename TestCoreDeploy -> TestCoreDeployer
  • Rename some file names to their class names
  • Remove runtime dependencies on Chai and Yargs
  • Replace Axios dep with cross-fetch
  • Setup type shorthand for Address type in SDK
  • Update infra package
  • Fix deploy's hardhat tests
  • Fix incorrect test in AbacusCoreChecker
  • Bump version to 0.3.0-beta and publish
  • Colocate tests into SDK src
  • Add instructions for publishing
  • Bump version to 0.3.0 and publish

@jmrossy jmrossy requested review from nambrot, yorhodes and tkporter June 23, 2022 17:49
@jmrossy jmrossy marked this pull request as ready for review June 28, 2022 16:56
yorhodes
yorhodes reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! thank you for taking this on

package.json Outdated Show resolved Hide resolved
solidity/app/package.json Outdated Show resolved Hide resolved
solidity/core/package.json Outdated Show resolved Hide resolved
typescript/infra/package.json Show resolved Hide resolved
typescript/infra/scripts/utils.ts Show resolved Hide resolved
typescript/sdk/src/utils/chains.ts Outdated Show resolved Hide resolved
typescript/sdk/src/utils/signer.ts Outdated Show resolved Hide resolved
typescript/sdk/test/gas/calculator.test.ts Outdated Show resolved Hide resolved
typescript/utils/package.json Outdated Show resolved Hide resolved
typescript/utils/src/utils.ts Show resolved Hide resolved
@jmrossy jmrossy requested a review from yorhodes July 1, 2022 17:05
nambrot
nambrot reviewed Jul 1, 2022
View reviewed changes
typescript/infra/scripts/utils.ts Show resolved Hide resolved
typescript/sdk/src/consts/chainMetadata.ts Outdated Show resolved Hide resolved
typescript/sdk/src/consts/chainMetadata.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/message.ts Show resolved Hide resolved
typescript/sdk/src/hardhat/TestCoreApp.ts Outdated Show resolved Hide resolved
typescript/sdk/src/hardhat/hardhatMultiProvider.ts Outdated Show resolved Hide resolved
@jmrossy jmrossy requested a review from nambrot July 2, 2022 16:03
@jmrossy jmrossy merged commit 86f280e into main Jul 5, 2022
@jmrossy jmrossy deleted the rossy/merge-sdk-deploy-hardhat branch July 5, 2022 18:59
@jmrossy jmrossy mentioned this pull request Jul 5, 2022
Closed
webbhorn added a commit that referenced this pull request Jul 6, 2022
@webbhorn
Revert "Merge SDK + Hardhat + Deploy packages (#643)"
cd13814 
This reverts commit 86f280e.
@yorhodes yorhodes mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes yorhodes approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@nambrot nambrot Awaiting requested review from nambrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge sdk packages
3 participants
@jmrossy @nambrot @yorhodes