Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support env subset deployments #767

Merged
merged 26 commits into from
Jul 28, 2022
Merged

Support env subset deployments #767

merged 26 commits into from
Jul 28, 2022

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Jul 14, 2022 •
edited
Loading

Fixes #394
Fixes #765

  • Support env subset deployements in AbacusCore and TestCore
  • Harden MultiProvider against missing chain values
  • Add tryGet* methods to MultiProvider and other convenience methods
  • Add getMultiProviderFromConfigAndProvider and getChainToOwnerMap utils to SDK
  • Make enrollRemoteRouters static in AbacusRouterDeployer
  • Create minimal envSubsetDeployer app in SDK to test subset chain deployments
  • Reduce boilerplate needed for HelloWorld app
  • Restructure HelloWorld check and deploy scripts to be more realistic
  • Add pick util function for objects
  • BREAKING CHANGE: Make order of generic types consistent across core classes
  • BREAKING CHANGE: Replace getMultiProviderFromSignerAndConfig with getTestMultiProvider

jmrossy added 18 commits July 7, 2022 18:22
@jmrossy
Use consistent dep versions across packages
c14fe62
@jmrossy
Add @abacus-network/helloworld back to monorepo
7241f36
@jmrossy
Copy over latest helloworld constructor change
69f39b7
@jmrossy
Minor tweak to readme and package.json deps
c6bcb18
@jmrossy
Fix lint and dockerfile
3e08879
@jmrossy
Merge branch 'main' into rossy/migrate-helloworld
30e2e50
@jmrossy
Create basic sync script for helloWorld package
8530de7 
Match lint and prettier pacakges in monorepo and template repo
@jmrossy
Add command to run yarn install after copy
70f0298
@jmrossy
Merge branch 'main' into rossy/migrate-helloworld
8e2c40d
@jmrossy
Merge branch 'rossy/migrate-helloworld' into rossy/migrate-helloworld…
ff191f7 
…-sync
@jmrossy
Add new methods and checks to multiprovider
4cce9df
@jmrossy
Merge branch 'main' into rossy/multiprovider-chain-subset
e7ca656
@jmrossy
Make generic type order consistent across main classes
40141c0
@jmrossy
Create basic envSubsetDeployer test app for sdk
57f9698
@jmrossy
Merge branch 'main' into rossy/multiprovider-chain-subset
90a7d12
@jmrossy
Create getChainToOwnerMap util function
69749da 
Make TestCoreDeploy and TestCoreApp generic
@jmrossy
Get single chain deployments working
dae79c0 
Update helloworld scripts to be more realistic
@jmrossy
Dedupe deploy code in envSubsetDeployer and AbacusRouterDeployer
cdbe587 
Remove use of signer in check scripts
@jmrossy jmrossy requested review from nambrot and yorhodes July 14, 2022 17:13
yorhodes
yorhodes reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

typescript/helloworld/src/scripts/check.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/AbacusCore.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/AbacusCore.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/TestCoreApp.ts Show resolved Hide resolved
typescript/sdk/src/deploy/router/AbacusRouterChecker.ts Show resolved Hide resolved
typescript/sdk/src/deploy/router/AbacusRouterDeployer.ts Outdated Show resolved Hide resolved
typescript/sdk/src/deploy/utils.ts Outdated Show resolved Hide resolved
typescript/sdk/src/utils/MultiGeneric.ts Show resolved Hide resolved
typescript/sdk/src/utils/MultiGeneric.ts Outdated Show resolved Hide resolved
typescript/sdk/src/utils/MultiGeneric.ts Outdated Show resolved Hide resolved
@jmrossy jmrossy requested a review from yorhodes July 19, 2022 14:12
nambrot
nambrot reviewed Jul 25, 2022
View reviewed changes
typescript/sdk/src/core/AbacusCore.ts Outdated Show resolved Hide resolved
typescript/sdk/src/deploy/utils.ts Outdated Show resolved Hide resolved
typescript/sdk/src/deploy/utils.ts Show resolved Hide resolved
typescript/sdk/src/deploy/utils.ts Outdated Show resolved Hide resolved
typescript/sdk/src/utils/MultiGeneric.ts Outdated Show resolved Hide resolved
@jmrossy jmrossy requested a review from nambrot July 27, 2022 22:22
@jmrossy jmrossy merged commit 44df310 into main Jul 28, 2022
@jmrossy jmrossy deleted the rossy/multiprovider-chain-subset branch July 28, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot approved these changes

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hardhat assumption from HelloWorld deploy and check scripts Make MultiProvider API more defensive
3 participants
@jmrossy @nambrot @yorhodes