This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: #2284 add capabilityChain for LD Proofs #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorllale
requested review from
sudeshrshetty,
kdimak,
fqutishat,
troyronda and
sandrask
Codecov Report
@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
+ Coverage 89.90% 89.91% +0.01%
==========================================
Files 227 227
Lines 15379 15396 +17
==========================================
+ Hits 13827 13844 +17
Misses 916 916
Partials 636 636
Continue to review full report at Codecov.
|
llorllale
force-pushed
the
2284
branch
3 times, most recently
from
1c05670 to
60b911e
Compare
Signed-off-by: George Aristy <[email protected]>
llorllale
changed the title
rolsonquadras
approved these changes
Oct 30, 2020
sudeshrshetty
approved these changes
Oct 30, 2020
sandrask
approved these changes
Oct 30, 2020
troyronda
approved these changes
Oct 30, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2284
This PR adds support for the
capabilityChainproperty in LD proofs. LD proofs withcapabilityChaincan be added withverifiable.Credential.AddLinkedDataProof()or more directly withsigner.DocumentSigner. They can be verified withverifiable.ParseCredential()andverifier.DocumentVerifier.Verify().capabilityChainis used in ZCAP-LD with aproofPurposeofcapabilityDelegation.Note: ZCAP-LD != Verifiable Credentials, so if the spec ever matures then we should add support for it in a new, separate API from
verifiable.Credential.Signed-off-by: George Aristy [email protected]