This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: BbsBlsSignatureProof2020 LDP suite for VC #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorllale
previously requested changes
Dec 7, 2020
|
|
||
| procOptions := prepareOpts(opts) | ||
|
|
||
| useDocumentLoader(options, procOptions.documentLoader, procOptions.documentLoaderCache) |
There was a problem hiding this comment.
@llorllale I absolutely agree that's not safe. But let's fix this all together for #1833
kdimak
requested review from
rolsonquadras,
fqutishat,
sudeshrshetty,
troyronda,
sandrask,
soluchok,
DRK3,
aholovko and
baha-ai
Codecov Report
@@ Coverage Diff @@
## master #2384 +/- ##
==========================================
- Coverage 89.47% 89.26% -0.21%
==========================================
Files 231 235 +4
Lines 16262 16459 +197
==========================================
+ Hits 14550 14692 +142
- Misses 1005 1042 +37
- Partials 707 725 +18
Continue to review full report at Codecov.
|
Signed-off-by: Dmitriy Kinoshenko <[email protected]>
kdimak
force-pushed
the
issue-2295-ldp
branch
from
b25b2ec to
8301ac0
Compare
llorllale
dismissed
their stale review
@dima as agreed to fix the CachingDocumentLoader thread-safety issue in a separate PR
fqutishat
approved these changes
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitriy Kinoshenko [email protected]
#2295