This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: support KMS with prefixed store namespace #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows a local KMS instance to be created with a prefixed store namespace closes hyperledger-archives#2435 Signed-off-by: Baha Shaaban <[email protected]>
baha-ai
requested review from
sudeshrshetty,
llorllale,
fqutishat,
troyronda and
rolsonquadras
sudeshrshetty
approved these changes
Jan 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #2482 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 250 250
Lines 18850 18851 +1
=======================================
+ Hits 16832 16833 +1
Misses 1187 1187
Partials 831 831
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Jan 22, 2021
sudeshrshetty
pushed a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Oct 18, 2021
…#2482) This change allows a local KMS instance to be created with a prefixed store namespace closes hyperledger-archives#2435 Signed-off-by: Baha Shaaban <[email protected]>
sudeshrshetty
pushed a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Jan 22, 2022
…#2482) This change allows a local KMS instance to be created with a prefixed store namespace closes hyperledger-archives#2435 Signed-off-by: Baha Shaaban <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows a local KMS instance to be created with a prefixed store namespace
closes #2435
Signed-off-by: Baha Shaaban [email protected]