This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqutishat
approved these changes
Feb 5, 2021
troyronda
commented
Feb 5, 2021
component/spi/storage/storage.go
Outdated
} | ||
|
||
// QueryOption represents an option for a Query call in a store. | ||
type QueryOption func(opts *QueryOptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: initially I was going to create a single spi package.
But currently this file is setup to be namespaced under a storage package so I left it for now.
What is "spi"/"SPI"? |
DRK3
approved these changes
Feb 5, 2021
Creates a Service Provider Interface (SPI) as a module. - Copies the interface from newstorage. - In a followup: remove the interface from newstorage. Signed-off-by: Troy Ronda <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2512 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 255 255
Lines 19690 19690
=======================================
Hits 17556 17556
Misses 1254 1254
Partials 880 880 Continue to review full report at Codecov.
|
sudeshrshetty
pushed a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Oct 18, 2021
Creates a Service Provider Interface (SPI) as a module. - Copies the interface from newstorage. - In a followup: remove the interface from newstorage. Signed-off-by: Troy Ronda <[email protected]>
sudeshrshetty
pushed a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Jan 22, 2022
Creates a Service Provider Interface (SPI) as a module. - Copies the interface from newstorage. - In a followup: remove the interface from newstorage. Signed-off-by: Troy Ronda <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a Service Provider Interface (SPI) as a module.
Signed-off-by: Troy Ronda [email protected]