Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: create initial spi module #2512

Merged
merged 1 commit into from
Feb 5, 2021
Merged

feat: create initial spi module #2512

merged 1 commit into from
Feb 5, 2021

Conversation

troyronda
Copy link
Contributor

@troyronda troyronda commented Feb 5, 2021

Creates a Service Provider Interface (SPI) as a module.

  • Copies the interface from newstorage.
  • In a followup: remove the interface from newstorage.

Signed-off-by: Troy Ronda [email protected]

}

// QueryOption represents an option for a Query call in a store.
type QueryOption func(opts *QueryOptions)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: initially I was going to create a single spi package.

But currently this file is setup to be namespaced under a storage package so I left it for now.

@DRK3
Copy link
Contributor

DRK3 commented Feb 5, 2021

What is "spi"/"SPI"?

@troyronda
Copy link
Contributor Author

Creates a Service Provider Interface (SPI) as a module.

- Copies the interface from newstorage.
- In a followup: remove the interface from newstorage.

Signed-off-by: Troy Ronda <[email protected]>
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #2512 (3164731) into main (5ef3d91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2512   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files         255      255           
  Lines       19690    19690           
=======================================
  Hits        17556    17556           
  Misses       1254     1254           
  Partials      880      880           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef3d91...b6bd9a1. Read the comment docs.

@troyronda troyronda merged commit f852f97 into hyperledger-archives:main Feb 5, 2021
@troyronda troyronda deleted the spi branch February 5, 2021 15:39
sudeshrshetty pushed a commit to sudeshrshetty/aries-framework-go that referenced this pull request Oct 18, 2021
Creates a Service Provider Interface (SPI) as a module.

- Copies the interface from newstorage.
- In a followup: remove the interface from newstorage.

Signed-off-by: Troy Ronda <[email protected]>
sudeshrshetty pushed a commit to sudeshrshetty/aries-framework-go that referenced this pull request Jan 22, 2022
Creates a Service Provider Interface (SPI) as a module.

- Copies the interface from newstorage.
- In a followup: remove the interface from newstorage.

Signed-off-by: Troy Ronda <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants