This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: BBS+ BDD tests for PE #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soluchok
requested review from
rolsonquadras,
llorllale,
aholovko,
troyronda,
fqutishat and
baha-ai
Codecov Report
@@ Coverage Diff @@
## main #2602 +/- ##
==========================================
- Coverage 88.63% 88.60% -0.03%
==========================================
Files 263 263
Lines 20335 20338 +3
==========================================
- Hits 18023 18021 -2
- Misses 1344 1347 +3
- Partials 968 970 +2
Continue to review full report at Codecov.
|
Signed-off-by: Andrii Soluk <[email protected]>
fqutishat
approved these changes
Mar 4, 2021
sudeshrshetty
approved these changes
Mar 4, 2021
rolsonquadras
approved these changes
Mar 4, 2021
baha-ai
reviewed
Mar 4, 2021
Comment on lines
+164
to
+170
| idSplit := strings.Split(opts.VerificationMethod, "#") | ||
| if len(idSplit) == creatorParts { | ||
| return idSplit[1] | ||
| } | ||
|
|
||
| return "" | ||
| } |
There was a problem hiding this comment.
is this logic still relevant? this is not a kms KID value
There was a problem hiding this comment.
I don't want to remove it because it will break compatibility (especially before release). Some services might depend on it.
aholovko
approved these changes
Mar 4, 2021
baha-ai
approved these changes
Mar 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrii Soluk [email protected]