This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
refactor: set DIDcomm V1 VS V2 Endpoint support #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baha-ai
requested review from
rolsonquadras,
troyronda,
Moopli,
fqutishat and
sudeshrshetty
baha-ai
force-pushed
the
endpoint_refactor
branch
6 times, most recently
from
7c61b6c to
94b339f
Compare
baha-ai
changed the title
baha-ai
force-pushed
the
endpoint_refactor
branch
2 times, most recently
from
085da23 to
60322cb
Compare
Codecov Report
@@ Coverage Diff @@
## main #3239 +/- ##
==========================================
- Coverage 88.75% 88.34% -0.41%
==========================================
Files 309 310 +1
Lines 41766 42257 +491
==========================================
+ Hits 37068 37334 +266
- Misses 3422 3615 +193
- Partials 1276 1308 +32
Continue to review full report at Codecov.
|
baha-ai
force-pushed
the
endpoint_refactor
branch
4 times, most recently
from
c889052 to
2f3774c
Compare
baha-ai
force-pushed
the
endpoint_refactor
branch
4 times, most recently
from
6c24a7a to
6c6ebaa
Compare
fqutishat
previously requested changes
May 23, 2022
baha-ai
force-pushed
the
endpoint_refactor
branch
4 times, most recently
from
3ba93f7 to
af4c507
Compare
baha-ai
force-pushed
the
endpoint_refactor
branch
3 times, most recently
from
692c461 to
0239db4
Compare
fqutishat
approved these changes
May 26, 2022
This change sets back the original DIDComm V1's Endpoint logic that was supperceded with the Endpoint struct update for DIDComm V2. With this change, both ServiceEndpoint structures for V1 and V2 are not supported. closes hyperledger-archives#3219 Signed-off-by: Baha Shaaban <[email protected]>
baha-ai
force-pushed
the
endpoint_refactor
branch
from
0239db4 to
967f08f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets back the original DIDComm V1's Endpoint logic that was supperceded with the Endpoint struct update for DIDComm V2.
With this change, both ServiceEndpoint structures for V1 and V2 are not supported.
closes #3219
Signed-off-by: Baha Shaaban [email protected]