This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: support of presentation exchange v2. #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkubiv
force-pushed
the
feat-presentation-exchenge-v2-support
branch
2 times, most recently
from
5e6f058 to
9612649
Compare
Codecov Report
@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
- Coverage 88.06% 88.05% -0.01%
==========================================
Files 318 318
Lines 43092 43152 +60
==========================================
+ Hits 37947 37998 +51
- Misses 3793 3799 +6
- Partials 1352 1355 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Moopli
approved these changes
Aug 2, 2022
Comment on lines
+972
to
+978
| for _, credential := range credentials { | ||
| for _, proofType := range format.LdpVP.ProofType { | ||
| if hasProofWithType(credential, proofType) { | ||
| result = append(result, credential) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
how we are handling JWT VC here?
Do we have a follow up task on that?
There was a problem hiding this comment.
We can add JWT VC to the list of supported formats here.
sudeshrshetty
approved these changes
Aug 2, 2022
vkubiv
force-pushed
the
feat-presentation-exchenge-v2-support
branch
from
9612649 to
98b9569
Compare
Signed-off-by: Volodymyr Kubiv <[email protected]>
vkubiv
force-pushed
the
feat-presentation-exchenge-v2-support
branch
from
98b9569 to
0f46750
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Kubiv [email protected]
Title:
Presentation exchange v2
Description:
#3297
Summary:
Added support of changes from the latest presentation exchange draft https://identity.foundation/presentation-exchange/