This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
fix: support of vp referencing in descriptor_map's path. #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkubiv
force-pushed
the
fix-bug-with-vp-referncing-presex
branch
4 times, most recently
from
02e9998 to
ce5e1b3
Compare
Codecov Report
@@ Coverage Diff @@
## main #3417 +/- ##
=======================================
Coverage 87.57% 87.58%
=======================================
Files 343 343
Lines 46809 46832 +23
=======================================
+ Hits 40994 41017 +23
Misses 4318 4318
Partials 1497 1497
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vkubiv
force-pushed
the
fix-bug-with-vp-referncing-presex
branch
5 times, most recently
from
c8f5499 to
c2cd7f6
Compare
fqutishat
approved these changes
Oct 25, 2022
vkubiv
force-pushed
the
fix-bug-with-vp-referncing-presex
branch
from
c2cd7f6 to
5c49eff
Compare
Signed-off-by: Volodymyr Kubiv <[email protected]>
vkubiv
force-pushed
the
fix-bug-with-vp-referncing-presex
branch
from
5c49eff to
0197294
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Support of vp referencing in descriptor_map's path.
Summary:
Previous code expected that all items referenced in descriptor_map's path should be valid VC.
Now, this is required only for the most nested path.