Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: SD-JWT: Add NewFromVC to Issuer #3492

Merged

Conversation

sandrask
Copy link
Contributor

Pass VC into NewFromVC and the issuer will create selective disclosures for everything in vc->credential subject and add the fields from options.

Closes #3491

@sandrask sandrask changed the title feat: SD-JWT: Add NewFromVC to Issuer wip: SD-JWT: Add NewFromVC to Issuer Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #3492 (6563762) into main (5778522) will decrease coverage by 0.01%.
The diff coverage is 87.23%.

@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
- Coverage   87.66%   87.65%   -0.01%     
==========================================
  Files         350      350              
  Lines       47804    47837      +33     
==========================================
+ Hits        41906    41933      +27     
- Misses       4373     4377       +4     
- Partials     1525     1527       +2     
Impacted Files Coverage Δ
pkg/doc/sdjwt/issuer/issuer.go 90.86% <82.85%> (-1.75%) ⬇️
pkg/doc/sdjwt/common/common.go 92.68% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Pass VC into NewFromVC and the issuer will create selective disclosures for everything in vc->credential subject and add the fields from options.

Closes hyperledger-archives#3491

Signed-off-by: Sandra Vrtikapa <[email protected]>
@sandrask sandrask force-pushed the add-new-from-vc-to-sdjwt-issuer branch from 1984987 to 6563762 Compare January 24, 2023 15:04
@sandrask sandrask changed the title wip: SD-JWT: Add NewFromVC to Issuer feat: SD-JWT: Add NewFromVC to Issuer Jan 24, 2023
@fqutishat fqutishat merged commit e159c5b into hyperledger-archives:main Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SD-JWT: Add NewFromVC to Issuer
2 participants