This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
chore: Additional validation when creating disclosed claims (verifier) #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional validation when processing disclosures to assemble disclosed claims: - If there is more than one place where the digest is included, the Verifier MUST reject the Presentation. - If the claim name already exists at the same level, the Verifier MUST reject the Presentation. - If the claim value contains an object with an _sd key (at the top level or nested deeper), the Verifier MUST reject the Presentation. Closes hyperledger-archives#3519 Signed-off-by: Sandra Vrtikapa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3522 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 351 351
Lines 48301 48332 +31
=======================================
+ Hits 42365 42396 +31
Misses 4398 4398
Partials 1538 1538
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
approved these changes
Feb 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional validation when processing disclosures to assemble disclosed claims:
Closes #3519