build(plugin-satp-hermes): dist/lib/knex/knexfile.ts not under rootDir #3708
Assignees
Labels
bug
Something isn't working
IETF-SATP-Hermes
Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.
P2
Priority 2: High
Milestone
Comments
petermetz
added
bug
|
Thank you, Peter! |
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Dec 20, 2024
1. Moved the typescript knex sources into the appropriate directory to match the established patterns we use for building the code (./src/main/typescript/) This fixed the problem of the bundler not finding the knexfile sources. 2. Also refactored the runtime require calls of the knex files to be build-time import statements instead. This came with the benefit that we no longer require the linter to be turned off and also that compile time checks are in effect. In the future if we want to go back to importing the knex files dynamically we could do so by adding a parameter to the log repository constructor parameter object which could be holding the path to a knex file to be included at runtime. (though I would only do this if we have no other choice - by default we should always thrive to use the compiler and do as much at build time as possible). Fixes hyperledger-cacti#3708 Signed-off-by: Peter Somogyvari <[email protected]>
5 tasks
|
I encountered the same error initially when testing the command. However, after deleting the dist folder and building again, the error no longer occurred. It's possible that leftover files from previous builds were causing the issue. I also ran a git reset --hard on my folder to ensure everything was clean, and run it again. |
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Jan 17, 2025
1. Moved the typescript knex sources into the appropriate directory to match the established patterns we use for building the code (./src/main/typescript/) This fixed the problem of the bundler not finding the knexfile sources. 2. Also refactored the runtime require calls of the knex files to be build-time import statements instead. This came with the benefit that we no longer require the linter to be turned off and also that compile time checks are in effect. In the future if we want to go back to importing the knex files dynamically we could do so by adding a parameter to the log repository constructor parameter object which could be holding the path to a knex file to be included at runtime. (though I would only do this if we have no other choice - by default we should always thrive to use the compiler and do as much at build time as possible). Fixes hyperledger-cacti#3708 Signed-off-by: Peter Somogyvari <[email protected]>
RafaelAPB
pushed a commit
that referenced
this issue
Jan 17, 2025
1. Moved the typescript knex sources into the appropriate directory to match the established patterns we use for building the code (./src/main/typescript/) This fixed the problem of the bundler not finding the knexfile sources. 2. Also refactored the runtime require calls of the knex files to be build-time import statements instead. This came with the benefit that we no longer require the linter to be turned off and also that compile time checks are in effect. In the future if we want to go back to importing the knex files dynamically we could do so by adding a parameter to the log repository constructor parameter object which could be holding the path to a knex file to be included at runtime. (though I would only do this if we have no other choice - by default we should always thrive to use the compiler and do as much at build time as possible). Fixes #3708 Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Broken on both
mainandsatp-devcd packages/cactus-plugin-satp-hermes/ yarn ncc build ./dist/lib/main/typescript/plugin-satp-hermes-gateway-cli.js --minify --out=./dist/bundle/ncc/The interesting parts from the logs that the command above will produce:
[tsl] ERROR TS6059: File '/home/peter/a/cacti/packages/cactus-plugin-satp-hermes/dist/lib/knex/knexfile-remote.ts' is not under 'rootDir' '/home/peter/a/cacti/packages/cactus-plugin-satp-hermes/src'. 'rootDir' is expected to contain all source files. The file is in the program because: Root file specified for compilation [tsl] ERROR TS6059: File '/home/peter/a/cacti/packages/cactus-plugin-satp-hermes/dist/lib/knex/knexfile.ts' is not under 'rootDir' '/home/peter/a/cacti/packages/cactus-plugin-satp-hermes/src'. 'rootDir' is expected to contain all source files. The file is in the program because: Root file specified for compilation [tsl] ERROR in /home/peter/a/cacti/packages/cactus-plugin-satp-hermes/src/test/typescript/make-checks.ts(11,3) TS2304: Cannot find name 'expect'. [tsl] ERROR in /home/peter/a/cacti/packages/cactus-plugin-satp-hermes/src/test/typescript/make-checks.ts(12,3) TS2304: Cannot find name 'expect'. [tsl] ERROR in /home/peter/a/cacti/packages/cactus-plugin-satp-hermes/src/test/typescript/make-checks.ts(14,3) TS2304: Cannot find name 'expect'.2024-12-18-satp-hermes-ncc-bundle.crash.log
Acceptance Criteria
cc: @RafaelAPB
The text was updated successfully, but these errors were encountered: