Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update package-lock.json files #432

Closed
petermetz opened this issue Dec 17, 2020 · 1 comment · Fixed by #433
Closed

chore: update package-lock.json files #432

petermetz opened this issue Dec 17, 2020 · 1 comment · Fixed by #433
Assignees
@jagpreetsinghsasan
Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Milestone
v0.3.0

Comments

@petermetz
Copy link
Contributor

Description

There are some changes that npm keeps forcing into the package lock files.
These should not be sneaked in as part of otherwise not related commit so I created this issue to have something dedicated to it.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton
@petermetz petermetz added good-first-issue Good for newcomers dependencies Pull requests that update a dependency file Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Dec 17, 2020
@petermetz petermetz added this to the v0.3.0 milestone Dec 17, 2020
@jagpreetsinghsasan
Copy link
Contributor

I will be working on this.

jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 17, 2020
@jagpreetsinghsasan
chore(package-lock): update the package-lock.json
8b7bb7a 
	Primary change
	--------------

	1. Updated the package-lock.json file as an standalone commit, so it won't reflect in any other PR

	Fixes hyperledger-cacti#432

Signed-off-by: jagpreetsinghsasan <[email protected]>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Dec 17, 2020
Merged
petermetz pushed a commit that referenced this issue Dec 17, 2020
@jagpreetsinghsasan @petermetz
chore(package-lock): update the package-lock.json
2730bff 
	Primary change
	--------------

	1. Updated the package-lock.json file as an standalone commit, so it won't reflect in any other PR

	Fixes #432

Signed-off-by: jagpreetsinghsasan <[email protected]>
(cherry picked from commit 8b7bb7a)
petermetz pushed a commit that referenced this issue Dec 17, 2020
@jagpreetsinghsasan @petermetz
chore(package-lock): update the package-lock.json
6cbb880 
	Primary change
	--------------

	1. Updated the package-lock.json file as an standalone commit, so it won't reflect in any other PR

	Fixes #432

Signed-off-by: jagpreetsinghsasan <[email protected]>
(cherry picked from commit 8b7bb7a)
petermetz pushed a commit that referenced this issue Dec 18, 2020
@jagpreetsinghsasan @petermetz
chore(package-lock): update the package-lock.json
455414d 
	Primary change
	--------------

	1. Updated the package-lock.json file as an standalone commit, so it won't reflect in any other PR

	Fixes #432

Signed-off-by: jagpreetsinghsasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

chore(package-lock): update the package-lock.json jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan