Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: dangling package.json inside packages directory #682

Closed
petermetz opened this issue Mar 18, 2021 · 0 comments · Fixed by #719
Closed

refactor: dangling package.json inside packages directory #682

petermetz opened this issue Mar 18, 2021 · 0 comments · Fixed by #719
Assignees
@petermetz
Labels
dependencies Pull requests that update a dependency file Developer_Experience SPIKE Exploratory work to better scope additional effort

Comments

@petermetz
Copy link
Contributor

petermetz commented Mar 18, 2021 •
edited
Loading

Description

As a contributor I want to have a uniform build system for all packages across all platforms so that it's easier to learn and understand how to work on the project.

Right now there is a dangling file at ./packages/package.json which started out as a copy-paste version of the root package.json file and has evolved in the meantime. The task at hand here is to retire ./packages/package.json and have the packages that use it leverage the default build system instead which is powered by Lerna/Typescript/Webpack/watcher, etc.

The other important aspect of this is that by having the same build process for the mono-repo, all packages can use each other's code, allowing dependencies to be specified among packages which is the bare minimum as a first step for us to unify the codebase.

Acceptance Criteria

  1. npm run build and it's quicker brethren (npm run build:dev, npm run build:dev:backend, etc.) are all building the packages as expected
  2. Redundant ./packages/package.json is no longer needed nor present.
  3. The remaining redundant configuration files under ./packages/ are also no longer needed nor present.
  4. npm run watch support added to the packages that previously relied on ./packages/package.json

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo
@petermetz petermetz added dependencies Pull requests that update a dependency file Developer_Experience SPIKE Exploratory work to better scope additional effort labels Mar 18, 2021
@petermetz petermetz self-assigned this Mar 18, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 24, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
1cda05a 
…-cacti#682

WORK IN PROGRESS

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (dozens, but there are still many)
For now I just ignored most of these via configuration

TODO:

1. Does not seem to work with Node v12, gRPC fails to install (node-gyp build)
2. Validator logic that has dedicated packages needs to move into the connector codebase (need to clarify which part is the implementation of the validator logic)

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Mar 24, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Apr 17, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
ed3a0bd 
…-cacti#682

WORK IN PROGRESS

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (dozens, but there are still many)
For now I just ignored most of these via configuration

TODO:

1. Does not seem to work with Node v12, gRPC fails to install (node-gyp build)
2. Validator logic that has dedicated packages needs to move into the connector codebase (need to clarify which part is the implementation of the validator logic)

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Jun 21, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
d634d6c 
…-cacti#682

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (dozens, but there are still many)
For now I just ignored most of these via configuration
3. Did not move the jest config as per the request of Takuma,
will discuss later why that needs to be at the location exactly
where it is today.

TODO:

1. Does not seem to work with Node v12, gRPC fails to install (node-gyp build)
2. Validator logic that has dedicated packages needs to move into
the connector codebase (need to clarify which part is the implementation of the validator logic)
3. Move jest config to the package specific sub-directory with the rest
of the dangling files.
Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 23, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
a3a6799 
…-cacti#682

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (several hundreds of them)

TODO:

1. Examples to be converted into packages that are part of the build

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 28, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
3c6f038 
…-cacti#682

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (1000+)
3. Also migrated the cartrade example to import via the package

TODO:

1. Other examples to be converted into packages that are part of the build
2. Examples made to work with the build system as well

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Aug 4, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
5079f28 
…-cacti#682

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (1000+)
3. Also migrated the cartrade example to import via the package

TODO:

1. Other examples to be converted into packages that are part of the build
2. Examples made to work with the build system as well

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Aug 4, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
0a13eff 
…-cacti#682

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (1000+)
3. Also migrated the cartrade example to import via the package

TODO:

1. Other examples to be converted into packages that are part of the build
2. Examples made to work with the build system as well

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Sep 9, 2021
@petermetz
refactor: dangling package.json inside packages directory hyperledger…
456344f 
…-cacti#682

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (1000+)
3. Also migrated the cartrade example to import via the package

TODO:

1. Other examples to be converted into packages that are part of the build
2. Examples made to work with the build system as well

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit that referenced this issue Sep 10, 2021
@petermetz
refactor: dangling package.json inside packages directory #682
8e67048 
Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (1000+)
3. Also migrated the cartrade example to import via the package

TODO:

1. Other examples to be converted into packages that are part of the build
2. Examples made to work with the build system as well

Fixes #682

Signed-off-by: Peter Somogyvari <[email protected]>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@petermetz @RafaelAPB
refactor: dangling package.json inside packages directory hyperledger…
932da86 
…-cacti#682

Changes
-----------

1. Moved the dangling folders under the package that was created
2. Fixed linter errors (1000+)
3. Also migrated the cartrade example to import via the package

TODO:

1. Other examples to be converted into packages that are part of the build
2. Examples made to work with the build system as well

Fixes hyperledger-cacti#682

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
dependencies Pull requests that update a dependency file Developer_Experience SPIKE Exploratory work to better scope additional effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: dangling package.json inside packages directory #682 petermetz/cacti
1 participant
@petermetz