-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(besu): support besu v21.1.6 #1244
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1244 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 298 298
Lines 10743 10743
Branches 1321 1321
=======================================
Hits 7681 7681
Misses 2364 2364
Partials 698 698 Continue to review full report at Codecov.
|
469aaac
to
549a316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AzaharaC LGTM, before merging, please publish the container image built from this branch onto the official repo with the fully qualified tag of
ghcr.io/hyperledger/cactus-besu-21-1-6-all-in-one:2021-08-24--feat-1244
and then update the test cases to use that as well.
Make sure to also update the containerImageVersion
variables, leaving them as latest
is going to destabilize the tests over time so it has to be the exact tag/version.
@petermetz I changed the tests with the new tag of the image. When I run the tests, I get an error 500. |
@AzaharaC I didn't upload it, wanted to see first if you could do it because I realized the other day that the permissions are handled different on GHCR than on DockerHub (because Travis reported that he was able to publish official images himself) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment above ^^
549a316
to
f7762b4
Compare
@petermetz You are right! I was able to upload the image myself. I have already updated the PR. |
f7762b4
to
6662cf6
Compare
0eb0d05
to
4a5373d
Compare
Resolve #982