Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(besu): support besu v21.1.6 #1244

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

AzaharaC
Copy link
Contributor

Resolve #982

@AzaharaC AzaharaC self-assigned this Aug 19, 2021
@AzaharaC AzaharaC requested a review from petermetz August 19, 2021 12:28
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #1244 (4325618) into main (beefcef) will not change coverage.
The diff coverage is n/a.

❗ Current head 4325618 differs from pull request most recent head 47e43fb. Consider uploading reports for the commit 47e43fb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1244   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files         298      298           
  Lines       10743    10743           
  Branches     1321     1321           
=======================================
  Hits         7681     7681           
  Misses       2364     2364           
  Partials      698      698           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beefcef...47e43fb. Read the comment docs.

@AzaharaC AzaharaC requested a review from petermetz August 20, 2021 11:04
@AzaharaC AzaharaC marked this pull request as ready for review August 20, 2021 11:06
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AzaharaC LGTM, before merging, please publish the container image built from this branch onto the official repo with the fully qualified tag of
ghcr.io/hyperledger/cactus-besu-21-1-6-all-in-one:2021-08-24--feat-1244
and then update the test cases to use that as well.
Make sure to also update the containerImageVersion variables, leaving them as latest is going to destabilize the tests over time so it has to be the exact tag/version.

@petermetz petermetz requested review from takeutak and petermetz and removed request for jonathan-m-hamilton August 24, 2021 22:24
@AzaharaC
Copy link
Contributor Author

AzaharaC commented Aug 30, 2021

@petermetz I changed the tests with the new tag of the image. When I run the tests, I get an error 500.
I have checked the repository and cannot find this image tag. (https://github.com/orgs/hyperledger/packages?page=1)
Is it possible that you forgot to upload the image or that it is not visible?

@petermetz
Copy link
Contributor

Is it possible that you forgot to upload the image or that it is not visible?

@AzaharaC I didn't upload it, wanted to see first if you could do it because I realized the other day that the permissions are handled different on GHCR than on DockerHub (because Travis reported that he was able to publish official images himself)

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above ^^

@AzaharaC
Copy link
Contributor Author

@petermetz You are right! I was able to upload the image myself. I have already updated the PR.

@AzaharaC AzaharaC requested a review from petermetz August 31, 2021 11:25
@petermetz petermetz merged commit d715c67 into hyperledger-cacti:main Sep 8, 2021
@AzaharaC AzaharaC deleted the feat/besu-v21-1-6 branch September 15, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(connector-besu): support Besu v21.1.6
4 participants