fix: openapi-validation test for xdai plugin #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
+ Coverage 67.93% 68.63% +0.69%
==========================================
Files 301 301
Lines 10948 10948
Branches 1347 1347
==========================================
+ Hits 7438 7514 +76
+ Misses 2819 2733 -86
- Partials 691 701 +10
Continue to review full report at Codecov.
|
elenaizaguirre
force-pushed
the
openapi-validation-xdai
branch
from
51d65a0 to
0fdae88
Compare
petermetz
requested changes
Sep 1, 2021
...gin-ledger-connector-xdai/src/test/typescript/integration/openapi/openapi-validation.test.ts
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-xdai/src/main/typescript/plugin-ledger-connector-xdai.ts
Outdated
Show resolved
Hide resolved
elenaizaguirre
force-pushed
the
openapi-validation-xdai
branch
2 times, most recently
from
d1c926d to
6f44052
Compare
Includes tests for endpoints deployContractV1, invokeContractV1 and runTransactionV1, each of them with test cases: - Right request - Request including an invalid parameter - Request without a required parameter Closes hyperledger-cacti#1288 Relationed with hyperledger-cacti#847 Signed-off-by: Elena Izaguirre <[email protected]>
elenaizaguirre
force-pushed
the
openapi-validation-xdai
branch
from
6f44052 to
e701a15
Compare
elenaizaguirre
changed the title
petermetz
requested review from
takeutak and
petermetz
and removed request for
jonathan-m-hamilton
petermetz
approved these changes
Sep 14, 2021
takeutak
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes tests for endpoints deployContractV1,
invokeContractV1 and runTransactionV1, each of them
with test cases:
Closes: #1288
Relationed with #847
Signed-off-by: Elena Izaguirre [email protected]