feat(iroha): adding checkEmpty param to request

[travis-payne]

Depends on #1957

Current functionality did not make use of the newer additional parameter in the Iroha command

Closes: #1265
Signed-off-by: Travis Payne [email protected]

[travis-payne]

@petermetz
Currently the request params are accepted using an array of params, instead of named, typed params, generated using the OpenAPI. What's your opinion on refactoring this as part of the PR, also makes the optionality of the oldValue param a lot cleaner.

[petermetz]

@petermetz Currently the request params are accepted using an array of params, instead of named, typed params, generated using the OpenAPI. What's your opinion on refactoring this as part of the PR, also makes the optionality of the oldValue param a lot cleaner.

@travis-payne I agree. If we don't already have a separate task (so not within the scope of this) for the params refactor, we should (IIRC we did have a task for it though).

[petermetz]

@travis-payne Were you able to run the tests successfully with these changes? (Right now the tests are being skipped by default so the CI passing doesn't guarantee correctness)

[petermetz]

Rebased this onto upstream/main.
Will still need to verify that it actually works with the tests, but for that we first need the Iroha tests to be passing again.

[takeutak]

@petermetz This pull-request has been left unreviewed for a long time. What would you like to do? (still wait / close this PR / etc.)
I guess that this pull request can no longer be merged to the current branch because it has been a long time.

[github-actions]

This PR/issue depends on:

• test(connector-iroha): fix and unskip run-transaction-endpoint-v1.test #1957
  By Dependent Issues (🤖). Happy coding!

[petermetz]

@petermetz This pull-request has been left unreviewed for a long time. What would you like to do? (still wait / close this PR / etc.)
I guess that this pull request can no longer be merged to the current branch because it has been a long time.

@takeutak Agreed on all of those points. Let's close this down for now and if there's willingness for someone to take it over the finish line then we can re-open it anytime we want. Closing it for now to de-clutter the PR queue a little bit more.

[petermetz]

TODO: Manually verify that the tests are passing with these changes.