fix: shutdown hook configuration is using wrong config key #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-courtin
requested review from
jonathan-m-hamilton and
petermetz
as code owners
takeutak
approved these changes
Dec 3, 2021
petermetz
requested changes
Dec 6, 2021
m-courtin
force-pushed
the
fix-1619-shutdown-hook-configuration
branch
3 times, most recently
from
6a05bca to
16d1630
Compare
|
@petermetz: UTs are added and during debugging of the new UTs 2 additional bugs came up -> I will create corresponding bugs |
petermetz
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
@m-courtin Cheers, LGTM, I will merge this once the tests are passing (once the prerequisite PR was merged)
m-courtin
force-pushed
the
fix-1619-shutdown-hook-configuration
branch
from
16d1630 to
7d639a1
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <[email protected]>
Need to set apiServerOptions.configFile to empty string as otherwise the build pipeline is failing Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <[email protected]>
m-courtin
force-pushed
the
fix-1619-shutdown-hook-configuration
branch
from
00c61c0 to
edc463c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.
Depends on #1649
#1649 fix for faulty shutdownHook definition in the Config-Schema is needed to be approved first as this is enabling the unit tests within this PR to work in correct way-
Closes: #1619
Signed-off-by: Michael Courtin [email protected]