fix: plugin ledger connector xdai exception handling and upgrade TS #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leeyoungone
requested review from
jonathan-m-hamilton and
petermetz
as code owners
|
This PR/issue depends on:
|
Leeyoungone
force-pushed
the
plugin-ledger-connector-xdai-1740
branch
2 times, most recently
from
5da2b92 to
d83e25b
Compare
Introduce a log helper with static functions to get exception message / exception stack whatever is thrown or provided. Closes: hyperledger-cacti#1702 Signed-off-by: Michael Courtin <[email protected]>
Fixes hyperledger-cacti#1740 Signed-off-by: Youngone Lee <[email protected]>
Leeyoungone
force-pushed
the
plugin-ledger-connector-xdai-1740
branch
from
d83e25b to
c6e1987
Compare
petermetz
reviewed
Jan 14, 2022
| message: "Internal Server Error", | ||
| error: ex?.stack || ex?.message, | ||
| }); | ||
| if (ex instanceof Error) { |
There was a problem hiding this comment.
@Leeyoungone Let's wait with this until #1381 is resolved as well because that's what it really depends on and I don't know for sure yet how that's going to play out.
There was a problem hiding this comment.
Sounds good! So sorry, I've just been plugging away at this epic -- I can go ahead and wait till the dependent PRs are merged into main. Feel free to ignore the current PRs I have open for endpoint error handling !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1707
Depends on #1381
Fixes #1740