fix: plugin ledger connector quorum exception handling and upgrade TS #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leeyoungone
requested review from
jonathan-m-hamilton and
petermetz
as code owners
Leeyoungone
changed the title
Leeyoungone
force-pushed
the
plugin-ledger-connector-quorum-1738
branch
from
a976414 to
f254be1
Compare
|
This PR/issue depends on:
|
Leeyoungone
force-pushed
the
plugin-ledger-connector-quorum-1738
branch
2 times, most recently
from
6e8da4c to
c594a0f
Compare
Introduce a log helper with static functions to get exception message / exception stack whatever is thrown or provided. Closes: hyperledger-cacti#1702 Signed-off-by: Michael Courtin <[email protected]>
Fixes hyperledger-cacti#1738 Signed-off-by: Youngone Lee <[email protected]>
Leeyoungone
force-pushed
the
plugin-ledger-connector-quorum-1738
branch
from
c594a0f to
0e13208
Compare
petermetz
requested changes
Jan 14, 2022
There was a problem hiding this comment.
@Leeyoungone Let's wait with this one until the dependencies are resolved, it's tricky to review before then because correctness depends on how the dependencies will get resolved exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1707
Depends on #1381
Fixes #1738