feat(iroha-connector): implement validator interface #2048
Conversation
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
|
This is follow up PR on #1966, @izuru0 and @petermetz - please continue the review here. |
|
@petermetz @jagpreetsinghsasan (cc: @izuru0) |
packages/cactus-core-api/src/main/typescript/plugin/ledger-connector/i-socket-api-client.ts
Show resolved
Hide resolved
packages/cactus-core-api/src/main/typescript/plugin/ledger-connector/i-socket-api-client.ts
Show resolved
Hide resolved
outSH
force-pushed
the
iroha_monitor_stepniowski_pr
branch
from
19e545f to
4510948
Compare
outSH
force-pushed
the
iroha_monitor_stepniowski_pr
branch
from
4510948 to
438fe18
Compare
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Outdated
Show resolved
Hide resolved
...es/cactus-plugin-ledger-connector-iroha/src/main/typescript/plugin-ledger-connector-iroha.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ledger-connector-iroha/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ledger-connector-iroha/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ledger-connector-iroha/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
@outSH @takeutak @izuru0 Very sorry for the slow review on this one (and all the other ones). We are finally back online with the CI so I'll have a little more time for these and also to merge the long pending PRs ASAP! |
outSH
force-pushed
the
iroha_monitor_stepniowski_pr
branch
from
438fe18 to
4f61ad2
Compare
|
@petermetz I've just pushed commit that contains fixes to your comments and some additional improvements, please review. Also, there must be two separate commits (mine and Piotr's) for copyright reasons. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Fixed
Show resolved
Hide resolved
outSH
force-pushed
the
iroha_monitor_stepniowski_pr
branch
2 times, most recently
from
4bdb732 to
7aefe82
Compare
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/api-client/iroha-api-client.ts
Fixed
Show resolved
Hide resolved
@outSH Please next time don't duplicate the PRs. I just realized that I've been reviewing the same code... again. |
@outSH Could you break it up to two separate PRs in that case so that we know that both commits are stable (compiles and passes the tests on it's own) |
@petermetz As I described in the original PR, the author (P. Stepniowski) of this PR no longer works for us, we couldn't make changes in the old PR so I've opened the new one with his original commit and my changes to suit your review, fix CI etc...
Original commit doesn't pass the tests on it's own, so I'm afraid it's impossible. Initially I wanted to merge single coauthored commit but DCO CI was complaining about author and signoff mismatch. We can either push these two or silence DCO for this PR, don't know what are the other options here. |
outSH
force-pushed
the
iroha_monitor_stepniowski_pr
branch
from
7aefe82 to
3e9dad5
Compare
|
@petermetz Rebased with the main, please merge when possible. // EDIT - will fix the timeout issue soon |
outSH
force-pushed
the
iroha_monitor_stepniowski_pr
branch
from
3e9dad5 to
4c9fd7d
Compare
|
@petermetz All issues solved, please merge when possible. |
There was a problem hiding this comment.
@petermetz All issues solved, please merge when possible.
@outSH Sorry, but there seem to be more merge conflicts at the moment. Please fix and pass it back for review!
Add monitoring and sending async/sync requests to ledger via SocketIO. Closes: hyperledger-cacti#1941 Signed-off-by: stepniowskip <[email protected]>
- Fix issues spotted by petermetz in review of PR#2048 - Fix iroha functional tests. - Close socketio connections when they are not needed anymore. - Update verifier-client README. Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
iroha_monitor_stepniowski_pr
branch
from
4c9fd7d to
7d96b60
Compare
Conflicts fixed |
feat(iroha-connector): implement validator interface
Add monitoring and sending async/sync requests to ledger via SocketIO.
Closes: #1941
Author: stepniowskip [email protected]
Original PR: #1966