feat(cmd-socketio-server): support multiple BLP in single server #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
|
@jagpreetsinghsasan @izuru0 Please review (only the last commit) |
|
This PR/issue depends on:
|
outSH
force-pushed
the
blp_refactor_pr
branch
from
a3e20fb to
b3e9abf
Compare
@petermetz Resolved |
outSH
requested review from
petermetz
and removed request for
sandeepnRES and
takeutak
outSH
force-pushed
the
blp_refactor_pr
branch
from
b3e9abf to
0305f53
Compare
petermetz
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
@outSH Thank you! LGTM
At the same time though, I see this test failure which does not look like a flake. Could you please take a look?
FAIL packages/cactus-cmd-socketio-server/src/test/typescript/unit/cmd-socketio-blp-plugin.test.ts
● Test suite failed to run
ENOENT: no such file or directory, open '/etc/cactus/validator-registry-config.yaml'
67 |
68 | constructor(path: string) {
> 69 | const yamlText = fs.readFileSync(path, "utf8");
| ^
70 | const yamlObj = yaml.safeLoad(yamlText);
71 | this.ledgerPluginInfo = yamlObj.ledgerPluginInfo;
72 | this.signTxInfo = yamlObj.signTxInfo;
at new ValidatorRegistry (packages/cactus-cmd-socketio-server/src/main/typescript/verifier/validator-registry.ts:69:25)
at Object.<anonymous> (packages/cactus-cmd-socketio-server/src/main/typescript/routing-interface/util/DBAccess.ts:18:43)
at Object.<anonymous> (packages/cactus-cmd-socketio-server/src/main/typescript/routing-interface/util/LPInfoHolder.ts:8:1)
outSH
force-pushed
the
blp_refactor_pr
branch
from
0305f53 to
742fe49
Compare
@petermetz Oh yes. sorry I've missed that - should be fixed now :) |
outSH
force-pushed
the
blp_refactor_pr
branch
from
742fe49 to
46dbd01
Compare
|
@petermetz Rebased and tested - ready to merge |
- Add support for starting Cactus CMD SocketIO server with multiple Bussiness Logic Plugins (BLP). All required TransactionManagement request should be routed to the correct BLP. - Add optional onListening callback when starting the cactus cmd socketio server, to simplify tests. - Fix some bugs and hard-coded BLP Ids in TransactionManagement. - Add new unit tests to check newly added functionalities. Closes hyperledger-cacti#2102 Depends on hyperledger-cacti#2030 Signed-off-by: Michal Bajer <[email protected]>
petermetz
force-pushed
the
blp_refactor_pr
branch
from
46dbd01 to
1df78e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All required TransactionManagement request should be routed to the correct BLP.
Closes #2102
Depends on #2030
Signed-off-by: Michal Bajer [email protected]