-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): sync-ts-config script needs import assertion of type json #2164
fix(build): sync-ts-config script needs import assertion of type json #2164
Conversation
bd52bbf
to
91f7fc0
Compare
cdb68d4
to
82cb094
Compare
82cb094
to
cf7d390
Compare
cf7d390
to
997eab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
589b134
to
01baf2a
Compare
@petermetz already done it with the latest commit. I returned it all back on to the main function and now I created a variable for PROJECT_DIR + LERNA_JSON with |
Suggested edit: diff --git a/tools/sync-npm-deps-to-tsc-projects.ts b/tools/sync-npm-deps-to-tsc-projects.ts
index 93024ae2..79465bee 100644
--- a/tools/sync-npm-deps-to-tsc-projects.ts
+++ b/tools/sync-npm-deps-to-tsc-projects.ts
@@ -24,9 +24,10 @@ const main = async (argv: string[], env: NodeJS.ProcessEnv) => {
const PROJECT_DIR = path.join(SCRIPT_DIR, "../");
console.log(`SCRIPT_DIR=${SCRIPT_DIR}`);
console.log(`PROJECT_DIR=${PROJECT_DIR}`);
- const lernaJson = JSON.parse(
- await readFile(PROJECT_DIR + LERNA_JSON, "utf-8"),
- );
+
+ const lernaJsonStr = await readFile(PROJECT_DIR + LERNA_JSON, "utf-8");
+ const lernaJson = JSON.parse(lernaJsonStr);
+
const pkgJsonGlobPatterns = lernaJson.packages.map((it: string) =>
"./".concat(it).concat(`/${PACKAGE_JSON}`),
);
|
01baf2a
to
5552b99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez LGTM, thank you for the updates!
5552b99
to
981ffe5
Compare
Fixes hyperledger-cacti#2163 Signed-off-by: aldousalvarez <[email protected]>
981ffe5
to
51adcc3
Compare
Fixes #2163
Signed-off-by: aldousalvarez [email protected]