-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi): upgrade to 6.3.0 phase1 #2333
feat(openapi): upgrade to 6.3.0 phase1 #2333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan LGTM, thank you for breaking this up into more digestible chunks!
I did a rebase on it, hopefully the CI will start passing, it seemed like the build failed due to some network issue on the server side (couldn't fetch the jar of the openapi generator).
I tested it on my local machine and it worked fine.
@petermetz we will need this PR to be reviewed and merged first: #2272 (once 2272 gets merged, I will run a quick test again on this PR) |
@jagpreetsinghsasan Whaaat. Sorry I must've messed something up with the issue creation. I meant to define the tasks in a way that phase 2 depends on phase 1 being done first not the other way around. 😅 |
@petermetz , no no, you havent created the issues in the wrong order. The PR: #2272 is the phase 2 of generating kotlin clients Once that gets merged, I need to re-test this PR again (because now its 6.x version of openapi-generator in this PR, and even that might have some conflicts with the kotlin clients). This is phase 1 of 6.x version upgrade. |
This PR/issue depends on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan The build started breaking on the CI after rebasing, please take a look!
2023-04-18T04:58:36-ci-crash.log
57edb05
to
953fa3a
Compare
953fa3a
to
60a4cc6
Compare
c164902
to
a770361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan LGTM
FYI: I resolved the merge conflicts and rebased this onto upstream/main
Primary Changes --------------- 1. Updated openapitoos.json for various plugins to use 6.3.0 version of openapi generator 2. Relevant code for each plugin was generated openapitools.json is updated for the following plugins to incorporate 1) ------------------------------------------------------------ a. extensions/cactus-plugin-htlc-coordinator-besu b. packages/cactus-plugin-htlc-eth-besu c. packages/cactus-plugin-htlc-eth-besu-erc20 d. packages/cactus-plugin-ledger-connector-besu e. packages/cactus-plugin-ledger-connector-quorum f. packages/cactus-cmd-api-server g. packages/cactus-core-api h. packages/cactus-plugin-consortium-manual i. packages/cactus-plugin-keychain-aws-sm j. packages/cactus-plugin-keychain-azure-kv k. packages/cactus-plugin-keychain-google-sm l. packages/cactus-plugin-keychain-memory m. packages/cactus-plugin-keychain-memory-wasm n. packages/cactus-plugin-keychain-vault o. packages/cactus-plugin-ledger-connector-ubiquity p. packages/cactus-plugin-ledger-connector-xdai packages/cactus-plugin-odap-hermes q. examples/cactus-example-carbon-accounting-business-logic-plugin Fixes hyperledger-cacti#2298 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: jagpreetsinghsasan <[email protected]>
Commit to be reviewed
feat(openapi): upgrade to 6.3.0 phase1
Fixes #2298
Depends on #2272