Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-plugin-ledger-connector-ethereum): support London fork gas prices #2630

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Aug 21, 2023

  • Add legacy and EIP1559 gas configuration options to transaction requests.
  • Legacy gas configuration is updated to EIP1559 using the same logic as web3 libraries.
  • Update the tests to work with new API.
  • Added test suite to test new features - geth-transact-and-gas-fees.test.ts

Depends on #2581

Signed-off-by: Michal Bajer [email protected]

outSH added a commit to outSH/cactus that referenced this pull request Aug 22, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
    supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
    (and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)

Depends on: hyperledger-cacti#2630

Signed-off-by: Michal Bajer <[email protected]>
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Please resolve the merge conflicts, rebase, squash as needed, etc and then pass it back for review!

outSH added a commit to outSH/cactus that referenced this pull request Sep 11, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
    supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
    (and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)

Depends on: hyperledger-cacti#2630

Signed-off-by: Michal Bajer <[email protected]>
@github-actions
Copy link

This PR/issue depends on:

@outSH outSH force-pushed the london_fork_feat_pr branch from 9a7dc2c to b78f835 Compare October 2, 2023 10:34
@outSH outSH requested a review from petermetz October 2, 2023 10:36
@outSH outSH force-pushed the london_fork_feat_pr branch from b78f835 to bce2858 Compare October 2, 2023 12:15
@petermetz petermetz enabled auto-merge (squash) October 2, 2023 22:59
@petermetz petermetz disabled auto-merge October 2, 2023 23:00
@petermetz petermetz enabled auto-merge (rebase) October 2, 2023 23:00
@petermetz petermetz disabled auto-merge October 2, 2023 23:01
…s prices

- Add legacy and EIP1559 gas configuration options to transaction requests.
- Legacy gas configuration is updated to EIP1559 using the same logic as web3 libraries.
- Update the tests to work with new API.
- Added test suite to test new features - `geth-transact-and-gas-fees.test.ts`

Depends on: hyperledger-cacti#2581

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz force-pushed the london_fork_feat_pr branch from bce2858 to 80a89dd Compare October 2, 2023 23:02
@petermetz petermetz merged commit 80a89dd into hyperledger-cacti:main Oct 2, 2023
outSH added a commit to outSH/cactus that referenced this pull request Oct 3, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
    supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
    (and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)

Depends on: hyperledger-cacti#2630

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this pull request Oct 10, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
    supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
    (and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)

Depends on: hyperledger-cacti#2630

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit to outSH/cactus that referenced this pull request Oct 10, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
    supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
    (and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)

Co-authored-by: Peter Somogyvari <[email protected]>

1. Updated the yarn.lock file to reflect the changes in the package.json

Depends on: hyperledger-cacti#2630

Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this pull request Dec 21, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
    supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
    (and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)

Co-authored-by: Peter Somogyvari <[email protected]>

1. Updated the yarn.lock file to reflect the changes in the package.json

Depends on: hyperledger-cacti#2630

Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants