Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd-api-server): healthcheck broken due to missing wget binary #2895

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

petermetz
Copy link
Contributor

  1. wget now gets installed explicitly
  2. upgraded to ubuntu 22.04 LTS for the base image
  3. upgraded nodejs to v20 LTS and npm to v10
  4. Published the container image corresponding to this commit tagged as
    ghcr.io/hyperledger/cactus-cmd-api-server:2023-11-16-issue2894

[skip ci]

Fixes #2894

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. wget now gets installed explicitly
2. upgraded to ubuntu 22.04 LTS for the base image
3. upgraded nodejs to v20 LTS and npm to v10
3. Published the container image corresponding to this commit tagged as
`ghcr.io/hyperledger/cactus-cmd-api-server:2023-11-16-issue2894`

[skip ci]

Fixes hyperledger-cacti#2894

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz merged commit 8f1ca3f into hyperledger-cacti:main Nov 17, 2023
@petermetz petermetz deleted the petermetz/issue2894 branch November 17, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(cmd-api-server): healtcheck broken due to missing wget binary
3 participants