Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): workflow to ensure PR commit parity #3436

Merged
merged 1 commit into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/pr-commit-parity.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: PR - Commit Parity
'on':
pull_request:
branches:
- main
- dev
- petermetz/**
push:
branches:
- main
- dev

jobs:
pr-commit-parity:
name: PR and Commit messages Parity
runs-on: ubuntu-22.04
steps:
- uses: actions/[email protected]
- name: Use Node.js v18.18.2
uses: actions/[email protected]
with:
node-version: v18.19.0
- name: Execute pr-commit-parity script
run: node tools/pr-commit-parity.js ${{ github.event.pull_request.url }}
61 changes: 61 additions & 0 deletions tools/pr-commit-parity.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
export async function fetchJsonFromUrl(url) {
const fetchResponse = await fetch(url);
return fetchResponse.json();
}

//regex expressions
const PULL_REQ_REQUIREMENTS_REGEX = /\*\*Pull\sRequest\sRequirements(.|\n)*/gim;
const FIXES_OR_DEPENDS_REGEX = /(Fixes|Depends)(.|\n)*/gim;
const SIGNED_OFF_REGEX = /(")*Signed-off-by:(.|\s)*/gim;
const HYPHEN_REGEX = /(-)+/gm;
const BACKTICK_REGEX = /`+/gm;
const SPACE_REGEX = / +/gm;
const COMMIT_TO_BE_REVIEWED_REGEX = /("#*\s*Commit\sto\sbe\sreviewed)/gim;
const WHITESPACES_HARDCODED_REGEX = /(\r\n|\n|\r|\\r|\\n)/gm;

const args = process.argv.slice(2);
const pullReqUrl = args[0];

const prMetadata = await fetchJsonFromUrl(pullReqUrl);
const prBodyRaw = JSON.stringify(prMetadata.body);

let commitMessageList = [];
const commitMessagesMetadata = await fetchJsonFromUrl(pullReqUrl + "/commits");

commitMessagesMetadata.forEach((commitMessageMetadata) => {
commitMessageList.push(
commitMessageMetadata["commit"]["message"]
.replace(SIGNED_OFF_REGEX, "")
.replace(HYPHEN_REGEX, "")
.replace(BACKTICK_REGEX, "")
.replace(WHITESPACES_HARDCODED_REGEX, "")
.replace(FIXES_OR_DEPENDS_REGEX, "")
.replace(SPACE_REGEX, ""),
);
});

let prBodyStriped = prBodyRaw
.replace(PULL_REQ_REQUIREMENTS_REGEX, "")
.replace(FIXES_OR_DEPENDS_REGEX, "")
.replace(WHITESPACES_HARDCODED_REGEX, "")
.replace(SIGNED_OFF_REGEX, "")
.replace(HYPHEN_REGEX, "")
.replace(BACKTICK_REGEX, "")
.replace(COMMIT_TO_BE_REVIEWED_REGEX, "")
.replace(SPACE_REGEX, "");

let PR_BODY_IN_COMMIT_MESSAGES = false;
for (let commitMessageListIndex in commitMessageList) {
let commitMessage = commitMessageList[commitMessageListIndex];
if (commitMessage == prBodyStriped) PR_BODY_IN_COMMIT_MESSAGES = true;
}

if (!PR_BODY_IN_COMMIT_MESSAGES) {
console.error(
"PR Body does not match any existing commit message\n" +
"Please make sure that the PR Body matches to minimum one of the commit messages\n" +
"Please refer the following PR for reference: https://github.com/hyperledger/cacti/pull/3338\n" +
"And the commit message here: https://github.com/hyperledger/cacti/pull/3338/commits/47ebdec442d30fa48c8518b876c47c38097cf028\n",
);
process.exit(-1);
}
Loading