fix: dci lint errors #514 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a .dcilintignore file to specify which files are not possible to change without breaking third party dependencies. TODO: If and when these dependencies get swapped out or they release new versions with inclusive language, we'll need to update them accordingly and the ignore file as well. Fixes hyperledger-cacti#514 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added
documentation
takeutak
reviewed
Jan 29, 2021
|
|
||
| - c.f.: https://hyperledger-fabric.readthedocs.io/en/master/install.html#install-samples-binaries-and-docker-images | ||
| - c.f.: https://hyperledger-fabric.readthedocs.io/en/release-2.2/install.html |
There was a problem hiding this comment.
Would you change the URL to the following URL?
https://hyperledger-fabric.readthedocs.io/en/release-1.4/install.html
There was a problem hiding this comment.
Would you change the URL to the following URL?
https://hyperledger-fabric.readthedocs.io/en/release-1.4/install.html
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jan 29, 2021
Fixes hyperledger-cacti#516 (comment) Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
fix/dci-lint-errors-514
branch
from
47b08d3 to
2e13877
Compare
takeutak
approved these changes
Feb 1, 2021
ghost
pushed a commit
to kikoncuo/cactus
that referenced
this pull request
Feb 4, 2021
Fixes hyperledger-cacti#516 (comment) Signed-off-by: Peter Somogyvari <[email protected]>
ghost
pushed a commit
to kikoncuo/cactus
that referenced
this pull request
Feb 4, 2021
Fixes hyperledger-cacti#516 (comment) Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Jordi Giron <[email protected]>
ghost
pushed a commit
to kikoncuo/cactus
that referenced
this pull request
Feb 4, 2021
Fixes hyperledger-cacti#516 (comment) Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Jordi Giron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a .dcilintignore file to specify which files are
not possible to change without breaking third party dependencies.
TODO: If and when these dependencies get swapped out or they
release new versions with inclusive language, we'll need to
update them accordingly and the ignore file as well.
Fixes #514
Signed-off-by: Peter Somogyvari [email protected]