Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): supply chain example container image exact versions #751 #752

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

petermetz
Copy link
Contributor

Remove the specific versions from the Dockerfile so that instead what
gets installed is "whatever's latest that day". This is not preferred, but
since Alpine Package Manager disappears versions of packages after
the fact, we do not have a choice but to abandon our quest for
reproducible builds in this particular instance.

Fixes #751

Signed-off-by: Peter Somogyvari [email protected]

…edger-cacti#751

Remove the specific versions from the Dockerfile so that instead what
gets installed is "whatever's latest that day". This is not preferred, but
since Alpine Package Manager disappears versions of packages after
the fact, we do not have a choice but to abandon our quest for
reproducible builds in this particular instance.

Fixes hyperledger-cacti#751

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz added bug Something isn't working documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Mar 30, 2021
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit bfc9c19 into hyperledger-cacti:main Apr 2, 2021
@petermetz petermetz deleted the fix-751 branch April 2, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(docs): supply chain example container image exact versions
3 participants