-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align the implementation of the DIDCommV2 protocol in cloud and edge agents (body
property must be optional)
#115
Comments
6 tasks
goncalo-frade-iohk
added a commit
to hyperledger-identus/sdk-swift
that referenced
this issue
Jan 29, 2025
hyperledger-identus/identus#115 Signed-off-by: goncalo-frade-iohk <[email protected]>
goncalo-frade-iohk
added a commit
to hyperledger-identus/sdk-swift
that referenced
this issue
Jan 29, 2025
hyperledger-identus/identus#115 Signed-off-by: goncalo-frade-iohk <[email protected]>
6 tasks
Closed
6 tasks
goncalo-frade-iohk
added a commit
to hyperledger-identus/sdk-swift
that referenced
this issue
Feb 7, 2025
hyperledger-identus/identus#115 Signed-off-by: goncalo-frade-iohk <[email protected]>
coveloper
added a commit
to coveloper/identus-edge-agent-sdk-swift
that referenced
this issue
Feb 11, 2025
Signed-off-by: Jon Bauer <[email protected]> ci: update and remove breaking steps Signed-off-by: goncalo-frade-iohk <[email protected]> update build.yml for xcode16 Signed-off-by: Jon Bauer <[email protected]> feat(agent): the body on issue credential protocol messages can be null hyperledger-identus/identus#115 Signed-off-by: goncalo-frade-iohk <[email protected]> commits squashed
coveloper
added a commit
to coveloper/identus-edge-agent-sdk-swift
that referenced
this issue
Feb 11, 2025
Signed-off-by: Jon Bauer <[email protected]> ci: update and remove breaking steps Signed-off-by: goncalo-frade-iohk <[email protected]> update build.yml for xcode16 Signed-off-by: Jon Bauer <[email protected]> feat(agent): the body on issue credential protocol messages can be null hyperledger-identus/identus#115 Signed-off-by: goncalo-frade-iohk <[email protected]> commits squashed
coveloper
added a commit
to coveloper/identus-edge-agent-sdk-swift
that referenced
this issue
Feb 11, 2025
Signed-off-by: Jon Bauer <[email protected]> ci: update and remove breaking steps Signed-off-by: goncalo-frade-iohk <[email protected]> update build.yml for xcode16 Signed-off-by: Jon Bauer <[email protected]> feat(agent): the body on issue credential protocol messages can be null hyperledger-identus/identus#115 Signed-off-by: goncalo-frade-iohk <[email protected]> commits squashed
coveloper
added a commit
to coveloper/identus-edge-agent-sdk-swift
that referenced
this issue
Feb 11, 2025
Signed-off-by: Jon Bauer <[email protected]> ci: update and remove breaking steps Signed-off-by: goncalo-frade-iohk <[email protected]> update build.yml for xcode16 Signed-off-by: Jon Bauer <[email protected]> feat(agent): the body on issue credential protocol messages can be null hyperledger-identus/identus#115 Signed-off-by: goncalo-frade-iohk <[email protected]> commits squashed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
UPDATE:
body
property: to be fully compatible with DIDComm v2.0. It’s recommended always to have this attribute when sending a message, but allow the attribute not to exist when receiving.body
between the cloud agent and edge agents for each DIDCommV2 protocol and each message.In the current implementation (Identus 2.14+), the
body
property of the messages is not optional.It caused the inconsistencies and compatibility issues between the agents (cloud and edge)
An example of the issue is the
body
property in theissue-credential
record.In the cloud agent 1.40.0 the
body
wasformats
property was absent at all, but the edge agent TS tries to parse it as wellAfter refactoring the cloud-agent (circle json library was replaced with zio-json in this and this commits)
After cloud-agent 1.40.0, the
body
property became empty. No information is transmitted from the cloud to the edge agent:At the same time, the
body
property is optional in the DIDCommV2 specification, and propertiesgoal_code
andreplacement_id
are optional as well:So, the cloud and edge agent must treat the
body
property according to the spec.The text was updated successfully, but these errors were encountered: