ci: use the fixed mediator test suite version #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,8 @@ jobs: | |||
| ATALA_GITHUB_ACTOR: ${{ secrets.ATALA_GITHUB_ACTOR }} | |||
| ATALA_GITHUB_TOKEN: ${{ secrets.ATALA_GITHUB_TOKEN }} | |||
| REPORTS_DIR: "didcomm-v2-mediator-test-suite/target/site/serenity" | |||
| DIDCOMM_V2_TESTSUITE_VERSION: "v0.1.0" | |||
| MEDIATOR_DID: "did:peer:2.Ez6LSghwSE437wnDE1pt3X6hVDUQzSjsHzinpX3XFvMjRAm7y.Vz6Mkhh1e5CEYYq6JBUcTZ6Cp2ranCWRrv7Yax3Le4N59R6dd.SeyJ0IjoiZG0iLCJzIjoiaHR0cDovL2xvY2FsaG9zdCIsInIiOltdLCJhIjpbImRpZGNvbW0vdjIiXX0" | |||
There was a problem hiding this comment.
The "serviceEndpoint" : "http://localhost" has no port.
Maybe we should use some useful default.
You are replacing this value somewhere on runtime right?
| environment: | ||
| # Creates the identity: | ||
| - KEY_AGREEMENT_D=Z6D8LduZgZ6LnrOHPrMTS6uU2u5Btsrk1SGs4fn8M7c | ||
| - KEY_AGREEMENT_X=Sr4SkIskjN_VdKTn0zkjYbhGTWArdUNE4j_DmUpnQGw | ||
| - KEY_AUTHENTICATION_D=INXCnxFEl0atLIIQYruHzGd5sUivMRyQOzu87qVerug | ||
| - KEY_AUTHENTICATION_X=MBjnXZxkMcoQVVL21hahWAw43RuAG-i64ipbeKKqwoA | ||
| # - SERVICE_ENDPOINT=https://k8s-int.atalaprism.io/mediator | ||
| - SERVICE_ENDPOINT=http://localhost |
There was a problem hiding this comment.
hum also has no port here
I don't know how this works but LGTM (assuming that is working =p)
FabioPinheiro
approved these changes
Aug 29, 2023
mineme0110
pushed a commit
that referenced
this pull request
Apr 30, 2024
mineme0110
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Anton <Baliasnikov>
mineme0110
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Anton <Baliasnikov>
mineme0110
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
mineme0110
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: mineme0110 <[email protected]>
mineme0110
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shailesh Patil <[email protected]>
mineme0110
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shailesh Patil <[email protected]>
mineme0110
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shailesh Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DIDComm V2 Test Suite version in integration tests and add configuration DID as entry point for integration tests.