implement Clone, PartialEq, Eq for most types

Signed-off-by: Andrew Whitehead <[email protected]>

src/amcl.rs

@@ -210,6 +210,8 @@ impl Debug for PointG1 {
     }
 }
 
+impl Eq for PointG1 {}
+
 #[cfg(feature = "serde")]
 impl SerializableCryptoPrimitive for PointG1 {
     fn name() -> &'static str {
@@ -352,6 +354,8 @@ impl Debug for PointG2 {
     }
 }
 
+impl Eq for PointG2 {}
+
 #[cfg(feature = "serde")]
 impl SerializableCryptoPrimitive for PointG2 {
     fn name() -> &'static str {
@@ -414,6 +418,8 @@ impl PointG2Inf {
     }
 }
 
+impl Eq for PointG2Inf {}
+
 impl From<PointG2> for PointG2Inf {
     fn from(value: PointG2) -> Self {
         Self(value)
@@ -452,7 +458,7 @@ impl SerializableCryptoPrimitive for PointG2Inf {
 #[cfg(feature = "serde")]
 serializable_crypto_primitive!(PointG2Inf);
 
-#[derive(Copy, Clone, PartialEq)]
+#[derive(Copy, Clone, PartialEq, Eq)]
 pub struct GroupOrderElement {
     bn: BIG,
 }
@@ -714,6 +720,8 @@ impl Debug for Pair {
     }
 }
 
+impl Eq for Pair {}
+
 #[cfg(feature = "serde")]
 impl SerializableCryptoPrimitive for Pair {
     fn name() -> &'static str {

src/bn/openssl.rs

@@ -337,12 +337,17 @@ impl BigNumber {
         Ok(bn)
     }
 
-    // Question: Why does this need to be a Result? When is creating a BigNumber same as another
-    // BigNumber not possible given sufficient memory?
     pub fn try_clone(&self) -> ClResult<BigNumber> {
-        let mut openssl_bn = BigNum::from_slice(&self.openssl_bn.to_vec()[..])?;
-        openssl_bn.set_negative(self.is_negative());
-        Ok(BigNumber { openssl_bn })
+        Ok(Self {
+            openssl_bn: self.openssl_bn.to_owned()?,
+        })
+    }
+}
+
+impl Clone for BigNumber {
+    fn clone(&self) -> Self {
+        self.try_clone()
+            .expect("Error allocating memory for BigNumber")
     }
 }
 

src/bn/rust.rs

@@ -14,6 +14,7 @@ use serde::{de::Visitor, Deserialize, Deserializer, Serialize, Serializer};
 
 use crate::error::{Error as ClError, Result as ClResult};
 
+#[derive(Clone)]
 pub struct BigNumber {
     bn: BigInt,
 }