Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap direct response messages with Forward wrapper(s) #199

Merged

Conversation

andrewwhitehead
Copy link
Contributor

Fixes #198

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #199 into master will increase coverage by 0.63%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   71.58%   72.22%   +0.63%     
==========================================
  Files         218      218              
  Lines        9982     9988       +6     
==========================================
+ Hits         7146     7214      +68     
+ Misses       2836     2774      -62

Signed-off-by: Andrew Whitehead <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Sep 25, 2019

This pull request fixes 10 alerts when merging 2a5be41 into fd02a50 - view on LGTM.com

fixed alerts:

  • 4 for Variable defined multiple times
  • 3 for Mismatch between signature and use of an overridden method
  • 2 for First argument of a method is not named 'self'
  • 1 for Unused exception object

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review addition of check, handling of condition and new test cases.

@swcurran swcurran merged commit 5db1d89 into openwallet-foundation:master Sep 26, 2019
@andrewwhitehead andrewwhitehead deleted the unwrap-direct-response branch February 29, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message mishandled when return route decorator is used for recipient with routing enabled
3 participants