Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2041 - Issue JSON-LD has invalid Admin API documentation #2046

Merged
merged 4 commits into from
Dec 24, 2022

Conversation

jfblier-amplitude
Copy link
Contributor

@jfblier-amplitude jfblier-amplitude commented Dec 13, 2022

cc @swcurran @ianco

The demo AliceWantsAJsonCredential.md has invalid Admin API endpoints documented.

Signed-off-by: Jean-Francois Blier [email protected]

@swcurran
Copy link
Contributor

@ianco -- if you have time, please take a look.

@ianco
Copy link
Contributor

ianco commented Dec 16, 2022

The update looks good, a bunch of tests are failing so I'm trying to re-run again

@ianco
Copy link
Contributor

ianco commented Dec 16, 2022

Weird the code format check is failing on files that haven't been changed ...

@swcurran
Copy link
Contributor

Andrew mentioned it on the call today. We need a PR to fix that one line, so that it won't be an issue there after.

@ianco ianco enabled auto-merge December 19, 2022 14:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianco ianco merged commit 929a09a into openwallet-foundation:main Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants